Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: lib/html/scripts/systemhtml.py

Issue 11235060: Get rid of Dynamic. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/html/scripts/systemhtml.py
diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py
index 8d71416b8df41981f62b357458192ac617098575..e7a8ce2eb540141dd2aa77a381104cc4730927e5 100644
--- a/lib/html/scripts/systemhtml.py
+++ b/lib/html/scripts/systemhtml.py
@@ -889,7 +889,7 @@ class Dart2JSBackend(object):
if conversion:
return conversion.input_type
else:
- return self._NarrowInputType(type_name) if type_name else 'Dynamic'
+ return self._NarrowInputType(type_name) if type_name else 'dynamic'
body = self._members_emitter.Emit(
'\n'
@@ -950,7 +950,7 @@ class Dart2JSBackend(object):
# be conservative.
if param_type == verified_type:
if param_type in ['String', 'num', 'int', 'double', 'bool', 'Object']:
- param_type = 'Dynamic'
+ param_type = 'dynamic'
target_parameters.append(
'%s%s' % (TypeOrNothing(param_type), param_name))
@@ -981,7 +981,7 @@ class Dart2JSBackend(object):
argument = operation.arguments[i]
parameter_name = parameter_names[i]
test_type = self._DartType(argument.type.id)
- if test_type in ['Dynamic', 'Object']:
+ if test_type in ['dynamic', 'Object']:
checks[i] = '?%s' % parameter_name
elif test_type == parameter_types[i]:
checks[i] = 'true'

Powered by Google App Engine
This is Rietveld 408576698