Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: samples/ui_lib/layout/GridLayoutParams.dart

Issue 11235054: Removed IllegalAccessException and UnsupportedOperationException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: ADded test expectations. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/dart/byte_array_test.dart ('k') | samples/ui_lib/layout/GridTracks.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/ui_lib/layout/GridLayoutParams.dart
diff --git a/samples/ui_lib/layout/GridLayoutParams.dart b/samples/ui_lib/layout/GridLayoutParams.dart
index 586abbfe963624417dbf17408563fb88c47a1dab..942bb34637bc3c5024fea85df28eb1102725f9bb 100644
--- a/samples/ui_lib/layout/GridLayoutParams.dart
+++ b/samples/ui_lib/layout/GridLayoutParams.dart
@@ -44,7 +44,7 @@ class GridLayoutParams extends LayoutParams {
row = line.start;
if (line.length != null) {
if (rowSpan != null) {
- throw new UnsupportedOperationException(
+ throw new UnsupportedError(
'grid-row-span cannot be with grid-row that defines an end');
}
rowSpan = line.length;
@@ -58,7 +58,7 @@ class GridLayoutParams extends LayoutParams {
column = line.start;
if (line.length != null) {
if (columnSpan != null) {
- throw new UnsupportedOperationException(
+ throw new UnsupportedError(
'grid-column-span cannot be with grid-column that defines an end');
}
columnSpan = line.length;
@@ -73,12 +73,12 @@ class GridLayoutParams extends LayoutParams {
// better and resolve conflicts more intelligently.
if (row != null || column != null ||
rowSpan != null || columnSpan != null) {
- throw new UnsupportedOperationException(
+ throw new UnsupportedError(
'grid-cell cannot be used with grid-row and grid-column');
}
if (layout.template == null) {
- throw new UnsupportedOperationException(
+ throw new UnsupportedError(
'grid-cell requires that grid-template is set on the parent');
}
@@ -94,7 +94,7 @@ class GridLayoutParams extends LayoutParams {
if (columnSpan == null) columnSpan = 1;
if (row == null && column == null) {
- throw new UnsupportedOperationException('grid-flow is not implemented'
+ throw new UnsupportedError('grid-flow is not implemented'
+ ' so at least one row or one column must be defined');
}
« no previous file with comments | « runtime/tests/vm/dart/byte_array_test.dart ('k') | samples/ui_lib/layout/GridTracks.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698