chrome/browser/unload_browsertest.cc - Issue 11235048: Test suite that monitors the disposition of JS-created windows based on what

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/unload_browsertest.cc

Issue 11235048: Test suite that monitors the disposition of JS-created windows based on what (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review feedback, removed popup blocker code. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/unload_browsertest.cc

diff --git a/chrome/browser/unload_browsertest.cc b/chrome/browser/unload_browsertest.cc

index 9b72b335c67c5c952b7f5b3ba318f2f6a14f6da6..0b98a0024cc6380151b30b4d20c6726b84502183 100644

--- a/chrome/browser/unload_browsertest.cc

+++ b/chrome/browser/unload_browsertest.cc

@@ -395,7 +395,8 @@ IN_PROC_BROWSER_TEST_F(UnloadTest, BrowserCloseTabWhenOtherTabHasListener) {

content::WindowedNotificationObserver load_stop_observer(

content::NOTIFICATION_LOAD_STOP,

content::NotificationService::AllSources());

- content::SimulateMouseClick(chrome::GetActiveWebContents(browser()));

+ content::SimulateMouseClick(chrome::GetActiveWebContents(browser()), 0,

+ WebKit::WebMouseEvent::ButtonLeft);

observer.Wait();

load_stop_observer.Wait();

CheckTitle("popup");

« chrome/browser/ui/click_modifier_browsertest.cc ('K') | « chrome/browser/ui/click_modifier_browsertest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »