Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1123453003: Revert of Adds thunks for getting platform handles (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds thunks for getting platform handles (patchset #3 id:40001 of https://codereview.chromium.org/1113393002/) Reason for revert: Broke build. Original issue's description: > Adds thunks for getting platform handles > > BUG=none > TEST=none > R=viettrungluu@chromium.org > > Committed: https://crrev.com/8f7386b022c30b46325f8c67ba4d04d33606103b > Cr-Commit-Position: refs/heads/master@{#327937} TBR=viettrungluu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/781e65d533b63593da93b0fbaf2a181bffc57451 Cr-Commit-Position: refs/heads/master@{#327945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -219 lines) Patch
D mojo/platform_handle/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D mojo/platform_handle/platform_handle.h View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/platform_handle/platform_handle_exports.h View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/platform_handle/platform_handle_functions.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/platform_handle/platform_handle_private_thunks.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/platform_handle/platform_handle_private_thunks.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M mojo/runner/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/runner/native_application_support.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D mojo/runner/platform_handle_impl.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
Created Revert of Adds thunks for getting platform handles
5 years, 7 months ago (2015-05-01 18:21:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123453003/1
5 years, 7 months ago (2015-05-01 18:22:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-01 18:24:43 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 18:26:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/781e65d533b63593da93b0fbaf2a181bffc57451
Cr-Commit-Position: refs/heads/master@{#327945}

Powered by Google App Engine
This is Rietveld 408576698