Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1123443002: Revert of Oilpan: Enable lazy sweeping on non-oilpan builds (Closed)

Created:
5 years, 7 months ago by jbroman
Modified:
5 years, 7 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Enable lazy sweeping on non-oilpan builds (patchset #2 id:20001 of https://codereview.chromium.org/1055193004/) Reason for revert: Broke content_browsertests, preventing Blink from rolling. 3 tests failed: DevToolsAgentTest.DevToolsResumeOnClose V8SamplingProfilerTest.V8SamplingJitCodeEventsCollected V8SamplingProfilerTest.V8SamplingSamplesCollected See, for example: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/60276 Original issue's description: > Oilpan: Enable lazy sweeping on non-oilpan builds > > Currently lazy sweeping is enabled only on oilpan builds. Since the lazy sweeping has been stable on the oilpan builds for >3 months, I think it's now safe to enable it on non-oilpan builds as well. > > BUG=480837 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194808 TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
Created Revert of Oilpan: Enable lazy sweeping on non-oilpan builds
5 years, 7 months ago (2015-05-01 16:59:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123443002/1
5 years, 7 months ago (2015-05-01 17:00:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194812
5 years, 7 months ago (2015-05-01 17:00:56 UTC) #3
sof
lgtm, thanks for the help.
5 years, 7 months ago (2015-05-01 18:07:25 UTC) #4
haraken
5 years, 7 months ago (2015-05-02 02:29:05 UTC) #5
Message was sent while issue was closed.
LGTM, thanks for the revert!

Powered by Google App Engine
This is Rietveld 408576698