Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1123433002: Add a GN flag for the Windows multi-dll build. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
ddorwin, ddorwin, scottmg
CC:
chromium-reviews, sadrul, kalyank, chromoting-reviews_chromium.org, grt+watch_chromium.org, jam, wfh+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, caitkp+watch_chromium.org, piman+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a GN flag for the Windows multi-dll build. The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. Originally landed as https://codereview.chromium.org/1120803003/ TBR=scottmg@chromium.org TBR=ddorwin@chromium.org (widevine) CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/2b2364bb2c6fbb88e6a4550abeb9141bc7cb949c Cr-Commit-Position: refs/heads/master@{#327998}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : chrome watcher fix #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -68 lines) Patch
M build/config/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A build/config/chrome_build.gni View 1 1 chunk +23 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/mac/mac_sdk.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 2 3 4 5 10 chunks +56 lines, -20 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_watcher/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/policy.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 chunks +8 lines, -19 lines 0 comments Download
M chrome/version.gni View 3 chunks +20 lines, -4 lines 0 comments Download
M chrome_elf/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M content/app/BUILD.gn View 5 chunks +5 lines, -6 lines 0 comments Download
M content/public/app/BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/cdm/ppapi/BUILD.gn View 1 2 3 4 1 chunk +1 line, -7 lines 0 comments Download
M remoting/remoting_version.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/webapp/build_template.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/adobe/flash/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
brettw
Original CL is in patch set 1.
5 years, 7 months ago (2015-05-01 16:08:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123433002/20001
5 years, 7 months ago (2015-05-01 16:09:56 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/6634)
5 years, 7 months ago (2015-05-01 16:57:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123433002/40001
5 years, 7 months ago (2015-05-01 17:21:35 UTC) #7
ddorwin
third_party/widevine LGTM
5 years, 7 months ago (2015-05-01 17:41:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/6639)
5 years, 7 months ago (2015-05-01 17:56:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123433002/60001
5 years, 7 months ago (2015-05-01 18:19:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/6645)
5 years, 7 months ago (2015-05-01 19:12:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123433002/80001
5 years, 7 months ago (2015-05-01 19:27:20 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/6648)
5 years, 7 months ago (2015-05-01 20:40:13 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123433002/100001
5 years, 7 months ago (2015-05-01 21:31:06 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-01 22:36:36 UTC) #25
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 22:37:30 UTC) #26
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2b2364bb2c6fbb88e6a4550abeb9141bc7cb949c
Cr-Commit-Position: refs/heads/master@{#327998}

Powered by Google App Engine
This is Rietveld 408576698