Split the bit reader functionalities from the byte stream provider.

media/base/bit_reader_h264_unittest.cc

Index: media/base/bit_reader_h264_unittest.cc
diff --git a/media/base/bit_reader_h264_unittest.cc b/media/base/bit_reader_h264_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..dd94da5702d1016a6c855e2c72615e2238b18ba9
--- /dev/null
+++ b/media/base/bit_reader_h264_unittest.cc
@@ -0,0 +1,130 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[acolwell GONE FROM CHROMIUM, 2014/01/11 00:24:37]

s/2012/2014

[damienv1, 2014/01/13 22:41:06]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/bit_reader_h264.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace media {
+
+TEST(BitReaderH264Test, ReadStreamWithoutEscapeAndTrailingZeroBytes) {
+  const unsigned char rbsp[] = {0x01, 0x23, 0x45, 0x67, 0x89, 0xa0};
+  int dummy = 0;
+  BitReaderH264 reader(rbsp, sizeof(rbsp));
+
+  EXPECT_TRUE(reader.ReadBits(1, &dummy));
+  EXPECT_EQ(dummy, 0x00);
+  EXPECT_TRUE(reader.HasMoreRBSPData());
+
+  EXPECT_TRUE(reader.ReadBits(8, &dummy));
+  EXPECT_EQ(dummy, 0x02);
+  EXPECT_TRUE(reader.HasMoreRBSPData());
+
+  EXPECT_TRUE(reader.ReadBits(31, &dummy));
+  EXPECT_EQ(dummy, 0x23456789);
+  EXPECT_TRUE(reader.HasMoreRBSPData());
+
+  EXPECT_TRUE(reader.ReadBits(1, &dummy));
+  EXPECT_EQ(dummy, 1);
+  EXPECT_TRUE(reader.HasMoreRBSPData());
+
+  EXPECT_TRUE(reader.ReadBits(1, &dummy));
+  EXPECT_EQ(dummy, 0);
+  EXPECT_FALSE(reader.HasMoreRBSPData());
+}
+
+TEST(BitReaderH264Test, SingleByteStream) {
+  const unsigned char rbsp[] = {0x18};
+  int dummy = 0;
+  BitReaderH264 reader(rbsp, sizeof(rbsp));
+
+  EXPECT_TRUE(reader.HasMoreRBSPData());
+
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x01);
+  EXPECT_FALSE(reader.HasMoreRBSPData());
+}
+
+TEST(BitReaderH264Test, StopBitOccupyFullByte) {
+  const unsigned char rbsp[] = {0xab, 0x80};
+  int dummy = 0;
+  BitReaderH264 reader(rbsp, sizeof(rbsp));
+
+  EXPECT_TRUE(reader.HasMoreRBSPData());
+
+  EXPECT_TRUE(reader.ReadBits(8, &dummy));
+  EXPECT_EQ(dummy, 0xab);
+  EXPECT_FALSE(reader.HasMoreRBSPData());
+}
+
+TEST(BitReaderH264Test, EmulationPreventionByte) {
+  const unsigned char rbsp[] = {0xac, 0x00, 0x00, 0x03, 0x01, 0x03, 0xdc};
+  int dummy = 0;
+  BitReaderH264 reader(rbsp, sizeof(rbsp));
+
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0xa);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0xc);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x0);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x0);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x0);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x0);
+
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x0);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x1);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x0);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0x3);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0xd);
+  EXPECT_TRUE(reader.ReadBits(4, &dummy));
+  EXPECT_EQ(dummy, 0xc);
+}
+
+TEST(BitReaderH264Test, UnsignedExpGolombTest) {
+  // Bit string with exp golomb code delimiter:
+  // |0000 0100 111|1| |011|1|
+  // |0000 0000 0000 0000 0000 0000 0000 0000
+  // 1111 1111 0000 0010 0000 0011 0000 0000
+  // 0|000 0000
+  const uint8 buffer[] = {
+    0x04, 0xf7, 0x00, 0x00,
+    0x00, 0x00, 0xff, 0x02,
+    0x03, 0x00, 0x00};
+  uint32 dummy;
+  int code_size;
+  BitReaderH264 reader(buffer, sizeof(buffer));
+
+  EXPECT_TRUE(reader.ReadUE(&dummy, &code_size));
+  EXPECT_EQ(code_size, 11);
+  EXPECT_EQ(dummy, 38u);
+
+  EXPECT_TRUE(reader.ReadUE(&dummy, &code_size));
+  EXPECT_EQ(code_size, 1);
+  EXPECT_EQ(dummy, 0u);
+
+  // Not interested in the code size (= 3 in this case).
+  EXPECT_TRUE(reader.ReadUE(&dummy));
+  EXPECT_EQ(dummy, 2u);
+
+  EXPECT_TRUE(reader.ReadUE(&dummy, &code_size));
+  EXPECT_EQ(code_size, 1);
+  EXPECT_EQ(dummy, 0u);
+
+  EXPECT_FALSE(reader.ReadUE(&dummy, &code_size));
+  EXPECT_EQ(code_size, 65);
+
+  EXPECT_FALSE(reader.ReadUE(&dummy, &code_size));
+  EXPECT_LT(code_size, 0);
+}
+
+}  // namespace media