Pepper: Finish support for dev channel APIs.

Pepper: Finish support for dev channel APIs.

This change completes the wiring, adding a file to list dev channel interfaces,
analogous to what exists for different permissions today. We only need to
introduce interfaces_ppb_public_dev_channel.h since we don't anticipate
dev channel APIs with permissions other than NONE.

BUG=325403
R=dmichael@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241877

[dmichael (off chromium), 2013-12-18 18:42:38]

https://codereview.chromium.org/112343005/diff/20001/ppapi/proxy/interface_li...
File ppapi/proxy/interface_list.h (right):

https://codereview.chromium.org/112343005/diff/20001/ppapi/proxy/interface_li...
ppapi/proxy/interface_list.h:57: bool in_requires_dev_channel)
Is there a reason this can't be one of the values of Permission instead? We
should unify in there if possible...

[teravest, 2013-12-18 22:19:25]

This change now uses PERMISSION_DEV_CHANNEL instead.

[dmichael (off chromium), 2013-12-18 22:40:49]

lgtm, thanks!

https://codereview.chromium.org/112343005/diff/50001/ppapi/proxy/interface_li...
File ppapi/proxy/interface_list_unittest.cc (right):

https://codereview.chromium.org/112343005/diff/50001/ppapi/proxy/interface_li...
ppapi/proxy/interface_list_unittest.cc:35: PpapiPermissions(PERMISSION_NONE));
Might be good to make sure PERMISSION_DEV doesn't enable PERMISSION_DEV_CHANNEL
and vice versa...  just to make sure we don't get mixed up between "DEV" and
"DEV_CHANNEL". I think your CL is good, but I could imagine somebody making that
mistake if we don't have a test.

https://codereview.chromium.org/112343005/diff/50001/ppapi/shared_impl/ppapi_...
File ppapi/shared_impl/ppapi_permissions.h (right):

https://codereview.chromium.org/112343005/diff/50001/ppapi/shared_impl/ppapi_...
ppapi/shared_impl/ppapi_permissions.h:33: // Dev-channel interfaces.
A more verbose description contrasting with "DEV" might help anybody who looks
here and doesn't know the history there.

[teravest, 2013-12-18 23:18:13]

On Wed, Dec 18, 2013 at 3:40 PM,  <dmichael@chromium.org> wrote:
> lgtm, thanks!
>
>
>
https://codereview.chromium.org/112343005/diff/50001/ppapi/proxy/interface_li...
> File ppapi/proxy/interface_list_unittest.cc (right):
>
>
https://codereview.chromium.org/112343005/diff/50001/ppapi/proxy/interface_li...
> ppapi/proxy/interface_list_unittest.cc:35:
> PpapiPermissions(PERMISSION_NONE));
> Might be good to make sure PERMISSION_DEV doesn't enable
> PERMISSION_DEV_CHANNEL and vice versa...  just to make sure we don't get
> mixed up between "DEV" and "DEV_CHANNEL". I think your CL is good, but I
> could imagine somebody making that mistake if we don't have a test.

Fair enough, added tests.

>
>
https://codereview.chromium.org/112343005/diff/50001/ppapi/shared_impl/ppapi_...
> File ppapi/shared_impl/ppapi_permissions.h (right):
>
>
https://codereview.chromium.org/112343005/diff/50001/ppapi/shared_impl/ppapi_...
> ppapi/shared_impl/ppapi_permissions.h:33: // Dev-channel interfaces.
> A more verbose description contrasting with "DEV" might help anybody who
> looks here and doesn't know the history there.

Done.

>
> https://codereview.chromium.org/112343005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2013-12-19 17:10:54]

Committed patchset #5 manually as r241877.