Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 112343002: Merge ReliableQuicStream::WriteData with (Closed)

Created:
7 years ago by ramant (doing other things)
Modified:
7 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Merge ReliableQuicStream::WriteData with ReliableQuicStream::WriteOrBuffer, and make this method non-virtual. It turns out the only cases where it was overridden could easily be worked around. Remove ReliableQuicStream::WriteDataInternal and use a MakeIovec helper to work around it. Rename ReliableQuicStream::WritevDataInternal to ReliableQuicStream::WritevData. Rename QuicStream::WritevData to QuicStream::Writev. Cleanup of the various Write methods in ReliableQuicStream. Merge internal change: 57753091 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -76 lines) Patch
M net/quic/quic_crypto_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.h View 2 chunks +14 lines, -30 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 5 chunks +13 lines, -19 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 7 chunks +9 lines, -10 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
7 years ago (2013-12-11 02:05:41 UTC) #1
Ryan Hamilton
7 years ago (2013-12-11 23:54:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698