Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2888)

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 11234032: Webview tag creation should be using storage partitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disabling session storage test for isolated apps. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/web_view_browsertest.cc ('k') | chrome/browser/profiles/profile_impl_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index 3513690b68ed38f048d4875a29825f1ec7e618d2..7b4ad05e39d06844c301bd4a983987f1de97b9fb 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -735,18 +735,8 @@ net::URLRequestContextGetter* ProfileImpl::GetRequestContextForRenderProcess(
int renderer_child_id) {
content::RenderProcessHost* rph = content::RenderProcessHost::FromID(
renderer_child_id);
- content::StoragePartition* storage_partition = rph->GetStoragePartition();
-
- // TODO(nasko): Remove this conditional, once webview tag creates a proper
- // storage partition.
- if (rph->IsGuest()) {
- // For guest processes, we only allow in-memory partitions for now, so
- // hardcode the parameter here.
- return GetRequestContextForStoragePartition(
- storage_partition->GetPath(), true);
- }
- return storage_partition->GetURLRequestContext();
+ return rph->GetStoragePartition()->GetURLRequestContext();
}
net::URLRequestContextGetter* ProfileImpl::GetMediaRequestContext() {
@@ -761,15 +751,6 @@ ProfileImpl::GetMediaRequestContextForRenderProcess(
renderer_child_id);
content::StoragePartition* storage_partition = rph->GetStoragePartition();
- // TODO(nasko): Remove this conditional, once webview tag creates a proper
- // storage partition.
- if (rph->IsGuest()) {
- // For guest processes, we only allow in-memory partitions for now, so
- // hardcode the parameter here.
- return GetMediaRequestContextForStoragePartition(
- storage_partition->GetPath(), true);
- }
-
return storage_partition->GetMediaURLRequestContext();
}
« no previous file with comments | « chrome/browser/extensions/web_view_browsertest.cc ('k') | chrome/browser/profiles/profile_impl_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698