Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: chrome/test/base/testing_profile.cc

Issue 11234032: Webview tag creation should be using storage partitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More fixes on Albert's comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/testing_profile.cc
diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc
index e385877a67f1d65e2739145f06b57ca7b7642c17..75337039f09edc32d5eb84ccf1e12e36744f92cb 100644
--- a/chrome/test/base/testing_profile.cc
+++ b/chrome/test/base/testing_profile.cc
@@ -609,16 +609,7 @@ net::URLRequestContextGetter* TestingProfile::GetRequestContextForRenderProcess(
int renderer_child_id) {
content::RenderProcessHost* rph = content::RenderProcessHost::FromID(
renderer_child_id);
- content::StoragePartition* storage_partition = rph->GetStoragePartition();
-
- // TODO(nasko): Remove this conditional, once webview tag creates a proper
- // storage partition.
- if (rph->IsGuest()) {
- return GetRequestContextForStoragePartition(
- storage_partition->GetPath(), true);
- }
-
- return storage_partition->GetURLRequestContext();
+ return rph->GetStoragePartition()->GetURLRequestContext();
}
void TestingProfile::CreateRequestContext() {

Powered by Google App Engine
This is Rietveld 408576698