Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/compiler.cc

Issue 11234002: Enable redundancy elimination for array loads. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.h » ('j') | runtime/vm/flow_graph_optimizer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 13809)
+++ runtime/vm/compiler.cc (working copy)
@@ -215,7 +215,11 @@
optimizer.OptimizeComputations();
}
if (FLAG_common_subexpression_elimination) {
- DominatorBasedCSE::Optimize(flow_graph);
+ if (DominatorBasedCSE::Optimize(flow_graph)) {
+ // Do another round of CSE to take seconary effects into account.
srdjan 2012/10/19 14:45:50 s/seconary/secondary/
srdjan 2012/10/19 14:45:50 Can you give a brief example of secondary effects
Florian Schneider 2012/10/22 10:31:55 Done.
Florian Schneider 2012/10/22 10:31:55 Done.
+ // TODO(fschneider): Change to a one-pass optimization pass.
+ DominatorBasedCSE::Optimize(flow_graph);
+ }
}
if (FLAG_loop_invariant_code_motion &&
(parsed_function.function().deoptimization_counter() <
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.h » ('j') | runtime/vm/flow_graph_optimizer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698