Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1123393004: Check if the RenderView is alive before setting the plugin find handler (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 7 months ago
Reviewers:
bbudge
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if the RenderView is alive before setting the plugin find handler Presumably during destruction, the RenderView can be destroyed before the RenderFrame (since it only holds a weak pointer to it). We need to check whether it is alive before clearing the plugin find handler. BUG=487146 Committed: https://crrev.com/0926126d8735958202f2201350e6cdec16357fc8 Cr-Commit-Position: refs/heads/master@{#330320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
5 years, 7 months ago (2015-05-15 05:57:03 UTC) #2
bbudge
LGTM Hopefully this check only needs to be done during destruction of the plugin.
5 years, 7 months ago (2015-05-15 16:04:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123393004/1
5 years, 7 months ago (2015-05-18 00:15:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 01:13:19 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:33:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0926126d8735958202f2201350e6cdec16357fc8
Cr-Commit-Position: refs/heads/master@{#330320}

Powered by Google App Engine
This is Rietveld 408576698