Chromium Code Reviews| Index: ios/chrome/browser/find_in_page/resources/find_in_page.js |
| diff --git a/ios/chrome/browser/find_in_page/resources/find_in_page.js b/ios/chrome/browser/find_in_page/resources/find_in_page.js |
| index c1075824a5ac77237c54e9e345ffd54324d21e5f..1ff6292c68e20ebc3907e446e3d13cd368df2278 100644 |
| --- a/ios/chrome/browser/find_in_page/resources/find_in_page.js |
| +++ b/ios/chrome/browser/find_in_page/resources/find_in_page.js |
| @@ -3,13 +3,10 @@ |
| // found in the LICENSE file. |
| /** |
| - * This file is lifted from the GoogleMobile find tool. |
| + * Based heavily on code from the Google iOS app. |
| * |
| * @fileoverview A find in page tool. It scans the DOM for elements with the |
| * text being search for, and wraps them with a span that highlights them. |
| - * |
| - * @author bmcmahan@google.com (Benjamin McMahan) |
| - * |
| */ |
| /** |
| @@ -31,7 +28,7 @@ __gCrWeb['findInPage']['spans'] = []; |
| /** |
| * The list of frame documents. |
| - * TODO(justincohen): x-domain frames won't work. |
| + * TODO(ios): x-domain frames won't work. |
| * @type {Array.<Document>} |
| */ |
| __gCrWeb['findInPage'].frameDocs = []; |
| @@ -218,7 +215,7 @@ __gCrWeb['findInPage']['highlightWord'] = |
| */ |
| __gCrWeb['findInPage']['pumpSearch'] = function(timeout) { |
| var opt_split = false; |
| - // TODO(justincohen): It would be better if this DCHECKed. |
| + // TODO(ios): It would be better if this DCHECKed. |
|
stuartmorgan
2015/05/19 18:26:47
We should *never* be adding TODO(ios); it's a bad
sdefresne
2015/05/20 08:05:32
Acknowledged.
|
| if (__gCrWeb['findInPage'].searchInProgress == false) |
| return __gCrWeb['findInPage'].NO_RESULTS; |
| @@ -867,7 +864,7 @@ __gCrWeb['findInPage'].isVisible = function(elem) { |
| // only scroll the window, not any scrollable containers in the DOM itself. So |
| // for now this function returns false if the element is scrolled outside the |
| // viewable area of its ancestors. |
| - // TODO (jonwall): handle scrolling within the DOM. |
| + // TODO (ios): handle scrolling within the DOM. |
|
stuartmorgan
2015/05/19 18:26:47
TODO(
sdefresne
2015/05/20 08:05:32
Acknowledged.
|
| var pageHeight = __gCrWeb['findInPage'].getBodyHeight(); |
| var pageWidth = __gCrWeb['findInPage'].getBodyWidth(); |