ui/app_list/search_controller.cc - Issue 1123373007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) in directory src/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/search_controller.cc

Issue 1123373007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) in directory src/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up in ui/app_list, ui/ozone, ui/message_center directories Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/search_controller.cc

diff --git a/ui/app_list/search_controller.cc b/ui/app_list/search_controller.cc

index d0ee2ab36fe294e132c97f097dd5ff55cdbc0d41..453efd93cfaa0aff3ce52242a91eaf2ab04eb981 100644

--- a/ui/app_list/search_controller.cc

+++ b/ui/app_list/search_controller.cc

@@ -122,7 +122,7 @@ void SearchController::AddProvider(size_t group_id,

&SearchController::OnResultsChanged,

base::Unretained(this)));

mixer_->AddProviderToGroup(group_id, provider.get());

- providers_.push_back(provider.release()); // Takes ownership.

+ providers_.push_back(provider.Pass()); // Takes ownership.

sadrul 2015/05/21 14:44:53 Remove the comment at the end. The new code is fai

d.samantaray 2015/05/22 03:37:02 Done.

}

void SearchController::OnResultsChanged() {

« no previous file with comments | « no previous file | ui/app_list/search_provider.cc » ('j') | no next file with comments »