Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1123373003: Launch webstore widget app when unsupported printer is plugged in (Closed)

Created:
5 years, 7 months ago by tbarzic
Modified:
5 years, 7 months ago
Reviewers:
yoshiki, stevenjb, Dan Beam
CC:
chromium-reviews, extensions-reviews_chromium.org, hashimoto+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_cws_widget_scripts
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Launch webstore widget app when unsupported printer is plugged in This implements webstore_widget app window, and launches the app when the user click on the notification shown when an unsupported printer is detected. Note that the notification is behind switch --enable-printer-app-search TODO: setting app icon; error handling. BUG=477106 TEST=None Committed: https://crrev.com/bb6e47357e1142ffaeb7e091ecdb2a82be120d07 Cr-Commit-Position: refs/heads/master@{#330048}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : rebase #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : rebase #

Patch Set 14 : bump app version #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -29 lines) Patch
M chrome/browser/chromeos/dbus/printer_service_provider.cc View 1 2 3 4 6 chunks +38 lines, -10 lines 0 comments Download
M components/chrome_apps/webstore_widget/app/background.js View 1 2 3 4 5 6 7 8 1 chunk +27 lines, -1 line 0 comments Download
A components/chrome_apps/webstore_widget/app/compiled_resources.gyp View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A components/chrome_apps/webstore_widget/app/main.css View 1 2 3 4 5 6 1 chunk +60 lines, -0 lines 0 comments Download
A components/chrome_apps/webstore_widget/app/main.html View 1 1 chunk +29 lines, -0 lines 0 comments Download
A components/chrome_apps/webstore_widget/app/main.js View 1 2 3 4 5 6 7 8 1 chunk +188 lines, -0 lines 2 comments Download
A components/chrome_apps/webstore_widget/cws_widget/compiled_resources.gypi View 1 2 3 4 5 6 7 8 1 chunk +18 lines, -0 lines 0 comments Download
M components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js View 6 chunks +13 lines, -9 lines 0 comments Download
A components/chrome_apps/webstore_widget/externs/chrome_webstore_widget_private.js View 1 chunk +78 lines, -0 lines 0 comments Download
A + components/chrome_apps/webstore_widget/externs/webview_tag.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/chrome_apps/webstore_widget/manifest.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +11 lines, -2 lines 0 comments Download
M components/chrome_apps/webstore_widget_resources.grdp View 1 chunk +11 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/launch_param.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tbarzic
5 years, 7 months ago (2015-05-08 00:02:41 UTC) #2
yoshiki
lgtm
5 years, 7 months ago (2015-05-12 06:34:32 UTC) #3
tbarzic
+stvenjb: owner for chrome/browser/chromeos/dbus
5 years, 7 months ago (2015-05-12 18:23:11 UTC) #5
stevenjb
https://codereview.chromium.org/1123373003/diff/260001/components/chrome_apps/webstore_widget/app/main.js File components/chrome_apps/webstore_widget/app/main.js (right): https://codereview.chromium.org/1123373003/diff/260001/components/chrome_apps/webstore_widget/app/main.js#newcode9 components/chrome_apps/webstore_widget/app/main.js:9: //<include src="../../../../ui/webui/resources/js/cr/ui/dialogs.js"> Note: We should avoid committing commented out ...
5 years, 7 months ago (2015-05-14 23:28:05 UTC) #6
stevenjb
Owner lgtm
5 years, 7 months ago (2015-05-14 23:28:17 UTC) #7
Dan Beam
https://codereview.chromium.org/1123373003/diff/260001/components/chrome_apps/webstore_widget/app/main.js File components/chrome_apps/webstore_widget/app/main.js (right): https://codereview.chromium.org/1123373003/diff/260001/components/chrome_apps/webstore_widget/app/main.js#newcode9 components/chrome_apps/webstore_widget/app/main.js:9: //<include src="../../../../ui/webui/resources/js/cr/ui/dialogs.js"> On 2015/05/14 23:28:04, stevenjb wrote: > Note: ...
5 years, 7 months ago (2015-05-14 23:59:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123373003/260001
5 years, 7 months ago (2015-05-15 05:04:37 UTC) #12
commit-bot: I haz the power
Committed patchset #14 (id:260001)
5 years, 7 months ago (2015-05-15 05:40:11 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 05:40:58 UTC) #14
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/bb6e47357e1142ffaeb7e091ecdb2a82be120d07
Cr-Commit-Position: refs/heads/master@{#330048}

Powered by Google App Engine
This is Rietveld 408576698