Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 1123353008: Revert of Use function wrapper argument to expose internal arrays to native scripts. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use function wrapper argument to expose internal arrays to native scripts. (patchset #2 id:20001 of https://codereview.chromium.org/1127983003/) Reason for revert: custom snapshot builder failing. Original issue's description: > Use function wrapper argument to expose internal arrays to native scripts. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/a9b5a1795449d94387218d25baed2c2b3c4fbadc > Cr-Commit-Position: refs/heads/master@{#28354} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c39a0a75ad5066108b5e4dd10e14b3e0cff63b2d Cr-Commit-Position: refs/heads/master@{#28355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -265 lines) Patch
M src/array.js View 1 chunk +0 lines, -5 lines 0 comments Download
M src/bootstrapper.cc View 14 chunks +103 lines, -128 lines 0 comments Download
M src/contexts.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/date.js View 1 chunk +0 lines, -6 lines 0 comments Download
M src/harmony-array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-object.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-spread.js View 1 chunk +1 line, -7 lines 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 1 chunk +0 lines, -4 lines 0 comments Download
M src/math.js View 1 chunk +0 lines, -4 lines 0 comments Download
M src/messages.js View 2 chunks +2 lines, -7 lines 0 comments Download
M src/object-observe.js View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/promise.js View 1 chunk +0 lines, -5 lines 0 comments Download
M src/regexp.js View 1 chunk +0 lines, -6 lines 0 comments Download
M src/string.js View 1 chunk +0 lines, -5 lines 0 comments Download
M src/templates.js View 1 chunk +3 lines, -11 lines 0 comments Download
M src/uri.js View 1 chunk +0 lines, -4 lines 0 comments Download
M src/v8natives.js View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M test/mjsunit/regress/regress-1878.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Use function wrapper argument to expose internal arrays to native scripts.
5 years, 7 months ago (2015-05-12 07:25:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123353008/1
5 years, 7 months ago (2015-05-12 07:25:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 07:26:12 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 07:26:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c39a0a75ad5066108b5e4dd10e14b3e0cff63b2d
Cr-Commit-Position: refs/heads/master@{#28355}

Powered by Google App Engine
This is Rietveld 408576698