Issue 1123343007: iOS experiments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1123343007: iOS experiments (Closed)

Created:
5 years, 7 months ago by servolk

Modified:
5 years, 7 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

iOS experiments

Patch Set 1 #

Patch Set 2 : Exclude sse2 target on iOS #

Patch Set 3 : Moved media mime_util into a separate library to deal with iOS #

Patch Set 4 : Remove MEDIA_EXPORT from mime_util functions #

Patch Set 5 : Add media_unittests dependency on media_mime_util #

Patch Set 6 : Added media_blink dependency on media_mime_util #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+330 lines, -1431 lines)			Patch
M	components/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/html_viewer/web_mime_registry_impl.cc	View		4 chunks	+8 lines, -7 lines	0 comments	Download
M	components/mime_util/BUILD.gn	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/mime_util/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/mime_util/mime_util.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	components/mime_util/mime_util.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/child/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/child/assert_matching_enums.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/renderer/renderer_blink_platform_impl.cc	View		6 chunks	+10 lines, -9 lines	0 comments	Download
M	content/shell/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/shell/app/shell_main_delegate.cc	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	media/BUILD.gn	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download
M	media/base/BUILD.gn	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download
A	media/base/mime_util.h	View	1 2 3	1 chunk	+75 lines, -0 lines	0 comments	Download
A +	media/base/mime_util.cc	View		9 chunks	+22 lines, -571 lines	0 comments	Download
A	media/base/mime_util_unittest.cc	View		1 chunk	+154 lines, -0 lines	0 comments	Download
M	media/blink/BUILD.gn	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/blink/key_system_config_selector.cc	View		4 chunks	+7 lines, -6 lines	0 comments	Download
M	media/blink/media_blink.gyp	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/media.gyp	View	1 2 3 4	4 chunks	+15 lines, -0 lines	0 comments	Download
M	net/base/mime_util.h	View		3 chunks	+0 lines, -56 lines	0 comments	Download
M	net/base/mime_util.cc	View		9 chunks	+2 lines, -632 lines	0 comments	Download
M	net/base/mime_util_unittest.cc	View		3 chunks	+1 line, -141 lines	0 comments	Download