Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1123343006: Add components/ownership/OWNERS to ownership.gypi per-file OWNERS. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add components/ownership/OWNERS to ownership.gypi per-file OWNERS. BUG=none Committed: https://crrev.com/50e7ad4e2d79f127b06fd7ac6781de374fe1b015 Cr-Commit-Position: refs/heads/master@{#329425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
davidben
Per review comment in https://codereview.chromium.org/1128153003/. Perhaps we should move components/foo.gypi to components/foo/foo.gypi.
5 years, 7 months ago (2015-05-11 18:18:18 UTC) #2
erikwright (departed)
LGTM
5 years, 7 months ago (2015-05-11 18:20:52 UTC) #3
Dmitry Polukhin
lgtm
5 years, 7 months ago (2015-05-12 14:59:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123343006/1
5 years, 7 months ago (2015-05-12 16:52:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 16:59:56 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 17:00:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50e7ad4e2d79f127b06fd7ac6781de374fe1b015
Cr-Commit-Position: refs/heads/master@{#329425}

Powered by Google App Engine
This is Rietveld 408576698