Issue 1123343003: Place nvpr above tesselating path renderer in the chain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1123343003: Place nvpr above tesselating path renderer in the chain (Closed)

Created:
5 years, 7 months ago by Chris Dalton

Modified:
5 years, 7 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org, vbuzinov, Mark Kilgard

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Place nvpr above tesselating path renderer in the chain BUG=skia: Committed: https://skia.googlesource.com/skia/+/0ce02c3ac1ff412b14c275eaf918acd88b3f0774

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/gpu/GrAddPathRenderers_default.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123343003/1

5 years, 7 months ago (2015-05-06 20:02:18 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0ce02c3ac1ff412b14c275eaf918acd88b3f0774

5 years, 7 months ago (2015-05-06 20:16:47 UTC) #6

Kimmo Kinnunen

5 years, 7 months ago (2015-05-07 10:32:26 UTC) #7

Message was sent while issue was closed.

On 2015/05/06 20:16:47, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/0ce02c3ac1ff412b14c275eaf918acd88b3f0774

Chris, as mentioned before, this causes huge regression in the gms, since NVPR
fill codepath has been broken..

 https://code.google.com/p/skia/issues/detail?id=3308

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages