Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123313006: Revert of [Contextual Search] Remove opt-in code. (Closed)

Created:
5 years, 7 months ago by pedro (no code reviews)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Contextual Search] Remove opt-in code. (patchset #6 id:100001 of https://codereview.chromium.org/1103163004/) Reason for revert: It broke Clank bots. Original issue's description: > [Contextual Search] Remove opt-in code. > > This CL requires a downstream change: > https://chrome-internal-review.googlesource.com/#/c/214963/ > > BUG=482618 > R=donnd@chromium.org, dtrainor@chromium.org, thakis@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/277f043bb56fb1e4bb93d9d17fc3de4ada0eb81b TBR=donnd@chromium.org,mathp@chromium.org,dtrainor@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=482618 Committed: https://crrev.com/3104ff6da35c1347addf0a88d47a0121c47f7880 Cr-Commit-Position: refs/heads/master@{#330248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+860 lines, -45 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java View 5 chunks +33 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelAnimation.java View 5 chunks +19 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java View 21 chunks +221 lines, -32 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelStateHandler.java View 3 chunks +39 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java View 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 2 chunks +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/contextual_search/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/contextual_search/header.svg View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/resources/contextual_search/promo.css View 1 chunk +162 lines, -0 lines 0 comments Download
A chrome/browser/resources/contextual_search/promo.html View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/resources/contextual_search/promo.js View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/search/contextual_search_promo_source_android.h View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/search/contextual_search_promo_source_android.cc View 1 chunk +149 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pedro (no code reviews)
Created Revert of [Contextual Search] Remove opt-in code.
5 years, 7 months ago (2015-05-16 00:24:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123313006/1
5 years, 7 months ago (2015-05-16 00:26:22 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-16 00:26:26 UTC) #4
Nico
lgtm
5 years, 7 months ago (2015-05-16 00:27:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123313006/1
5 years, 7 months ago (2015-05-16 00:28:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-16 00:32:08 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:29:54 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3104ff6da35c1347addf0a88d47a0121c47f7880
Cr-Commit-Position: refs/heads/master@{#330248}

Powered by Google App Engine
This is Rietveld 408576698