Browser Plugin: Add 'crashed' exit type

Browser Plugin: Add 'crashed' exit type

BUG=none
Test=BrowserPluginTest.GuestCrash


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163502

[Fady Samuel, 2012-10-22 20:47:12]

Hi Mihai (Charlie in CC),

I added the missing termination status. Thanks for catching this.

Fady

[Mihai Parparita -not on Chrome, 2012-10-22 20:53:31]

LGTM

On Mon, Oct 22, 2012 at 1:47 PM,  <fsamuel@chromium.org> wrote:
> Reviewers: Mihai Parparita,
>
> Message:
> Hi Mihai (Charlie in CC),
>
> I added the missing termination status. Thanks for catching this.
>
> Fady
>
> Description:
> Browser Plugin: Add 'crashed' exit type
>
> BUG=none
> Test=BrowserPluginTest.GuestCrash
>
>
> Please review this at http://codereview.chromium.org/11233044/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M content/renderer/browser_plugin/browser_plugin.cc
>   M content/renderer/browser_plugin/browser_plugin_browsertest.cc
>
>
> Index: content/renderer/browser_plugin/browser_plugin.cc
> diff --git a/content/renderer/browser_plugin/browser_plugin.cc
> b/content/renderer/browser_plugin/browser_plugin.cc
> index
>
561801091e30a7ebf64d3c4608d2da864fdfaad0..699237624350543557535721f86d92f108b81cde
> 100644
> --- a/content/renderer/browser_plugin/browser_plugin.cc
> +++ b/content/renderer/browser_plugin/browser_plugin.cc
> @@ -66,6 +66,8 @@ static std::string
> TerminationStatusToString(base::TerminationStatus status) {
>        return "abnormal";
>      case base::TERMINATION_STATUS_PROCESS_WAS_KILLED:
>        return "killed";
> +    case base::TERMINATION_STATUS_PROCESS_CRASHED:
> +      return "crashed";
>      default:
>        // This should never happen.
>        DCHECK(false);
> Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc
> diff --git a/content/renderer/browser_plugin/browser_plugin_browsertest.cc
> b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
> index
>
d860226bfcc8d9542d8bf97ce4dde9e0493a30b4..f990c118ece9a9c1f47ebf8814d662ef5529084e
> 100644
> --- a/content/renderer/browser_plugin/browser_plugin_browsertest.cc
> +++ b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
> @@ -281,12 +281,18 @@ TEST_F(BrowserPluginTest, GuestCrash) {
>
>    ExecuteJavaScript(kAddEventListener);
>
> -  // Pretend that the guest has crashed
> +  // Pretend that the guest has terminated normally.
>    browser_plugin->GuestGone(0,
> base::TERMINATION_STATUS_NORMAL_TERMINATION);
>
>    // Verify that our event listener has fired.
>    EXPECT_EQ("normal", ExecuteScriptAndReturnString("msg"));
>
> +  // Pretend that the guest has crashed.
> +  browser_plugin->GuestGone(0, base::TERMINATION_STATUS_PROCESS_CRASHED);
> +
> +  // Verify that our event listener has fired.
> +  EXPECT_EQ("crashed", ExecuteScriptAndReturnString("msg"));
> +
>    // Send an event and verify that events are no longer deported.
>    browser_plugin->handleInputEvent(WebKit::WebMouseEvent(),
>                                     cursor_info);
>
>

[Fady Samuel, 2012-10-22 21:56:43]

+creis for OWNER approval.

[Charlie Reis, 2012-10-23 01:12:54]

LGTM.

[commit-bot: I haz the power, 2012-10-23 01:13:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11233044/1

[commit-bot: I haz the power, 2012-10-23 04:32:54]

Change committed as 163502