Use == instead of identical for integers.

Use == instead of identical for integers.

Committed: https://code.google.com/p/dart/source/detail?r=13875

[Mads Ager (google), 2012-10-22 13:14:40]

LGTM

[ahe, 2012-10-22 14:07:42]

Please put the compile-time constants on the left-hand side.

[ahe, 2012-10-30 06:48:07]

Any progress on addressing my comments?

[Lasse Reichstein Nielsen, 2012-10-30 08:37:06]

I actually prefer to read the constants on the right.

[ahe, 2012-10-30 10:04:10]

On 2012/10/30 08:37:06, Lasse Reichstein Nielsen wrote:
> I actually prefer to read the constants on the right.

I'm concerned about performance. I know the VM generates better code when the
constant is on the left-hand side.

[Florian Schneider, 2012-10-30 10:07:11]

On 2012/10/30 10:04:10, ahe wrote:
> On 2012/10/30 08:37:06, Lasse Reichstein Nielsen wrote:
> > I actually prefer to read the constants on the right.
> 
> I'm concerned about performance. I know the VM generates better code when the
> constant is on the left-hand side.

It should not matter performance-wise where you place the constants in a ==
expression. - If it still does, please file a bug against the VM.

[ahe, 2012-10-30 11:11:27]

On 2012/10/30 10:07:11, Florian Schneider wrote:
> On 2012/10/30 10:04:10, ahe wrote:
> > On 2012/10/30 08:37:06, Lasse Reichstein Nielsen wrote:
> > > I actually prefer to read the constants on the right.
> > 
> > I'm concerned about performance. I know the VM generates better code when
the
> > constant is on the left-hand side.
> 
> It should not matter performance-wise where you place the constants in a ==
> expression. - If it still does, please file a bug against the VM.

Adding a little more info here: I had assumed that 2 == x could basically be
compiled to an efficient check similar to 2 === x. However, Since 2 == 2.0 in
Dart, both 2 == x and x == 2 requires a SMI check.

In that case, let's keep the code as is.