Fix deletion of hidden property with inline-stored hash.

Fix deletion of hidden property with inline-stored hash.

R=yangguo@chromium.org
BUG=chromium:157124
TEST=cctest/test-api/Regress157124

Committed: https://code.google.com/p/v8/source/detail?r=12785

[Yang, 2012-10-22 12:35:17]

On 2012/10/22 12:19:38, Michael Starzinger wrote:

LGTM with (somewhat unrelated) comments.

[Yang, 2012-10-22 12:35:23]

https://codereview.chromium.org/11233033/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/11233033/diff/1/src/objects.cc#newcode3624
src/objects.cc:3624: ASSERT(!hidden_lookup->IsFailure());  // No failure when
passing false as arg.
Not your fault, but what I think what I was trying to say (lost during
refactoring I guess) is that "No failure when merely fetching inline value".

https://codereview.chromium.org/11233033/diff/1/src/objects.cc#newcode3667
src/objects.cc:3667: ASSERT(!hidden_lookup->IsFailure());  // No failure when
passing false as arg.
Ditto.

[Michael Starzinger, 2012-10-22 12:45:52]

Addressed comments. Landing.

https://codereview.chromium.org/11233033/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/11233033/diff/1/src/objects.cc#newcode3624
src/objects.cc:3624: ASSERT(!hidden_lookup->IsFailure());  // No failure when
passing false as arg.
On 2012/10/22 12:35:23, Yang wrote:
> Not your fault, but what I think what I was trying to say (lost during
> refactoring I guess) is that "No failure when merely fetching inline value".

Done. As discussed offline, the whole assertion can be removed because
ToObjectUnchecked() asserts the same condition.

https://codereview.chromium.org/11233033/diff/1/src/objects.cc#newcode3667
src/objects.cc:3667: ASSERT(!hidden_lookup->IsFailure());  // No failure when
passing false as arg.
On 2012/10/22 12:35:23, Yang wrote:
> Ditto.

Done. Likewise.