Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1123283011: Use ScopedObserver to observe the SupervisedUserSyncService in SupervisedUserImportHandler. (Closed)

Created:
5 years, 7 months ago by Bernhard Bauer
Modified:
5 years, 7 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, michaelpg+watch-options_chromium.org, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedObserver to observe the SupervisedUserSyncService in SupervisedUserImportHandler. In addition to simplifying the code, ScopedObserver ensures that the object is unregistered as an observer if and only if it has been registered. BUG=488642 Committed: https://crrev.com/593dd520027d2bcf9dbfeef22fe99d40220087f7 Cr-Commit-Position: refs/heads/master@{#330536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/browser/ui/webui/options/supervised_user_import_handler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_import_handler.cc View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bernhard Bauer
Please review. Thanks!
5 years, 7 months ago (2015-05-18 16:14:40 UTC) #2
Marc Treib
On 2015/05/18 16:14:40, Bernhard Bauer wrote: > Please review. Thanks! lgtm
5 years, 7 months ago (2015-05-19 08:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123283011/1
5 years, 7 months ago (2015-05-19 15:13:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 17:13:39 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:14:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/593dd520027d2bcf9dbfeef22fe99d40220087f7
Cr-Commit-Position: refs/heads/master@{#330536}

Powered by Google App Engine
This is Rietveld 408576698