GN: Don't generate phony rules called "all".

GN: Don't generate phony rules called "all".

These collide with the built-in rule. Mark this name used so the phony rule writer won't make phony rules for things called "all".

Don't write phony rules that collide with output files.

BUG=485275
Committed: https://crrev.com/22d6ca1804b55d97852dc6c92e480f173c3909a8
Cr-Commit-Position: refs/heads/master@{#329022}

[brettw, 2015-05-07 19:59:20]

brettw@chromium.org changed reviewers:
+ msw@chromium.org

[brettw, 2015-05-07 19:59:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-07 20:00:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123283003/1

[commit-bot: I haz the power, 2015-05-07 20:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 20:57:47]

Dry run: This issue passed the CQ dry run.

[msw, 2015-05-08 19:51:48]

So for the case of //mandoline/BUILD.gn containing group("all"), this won't
generate a corresponding target named "all" (since that is a reserved GN/ninja
target name), but GN will still generate a target named "mandoline:all"? If so,
then this lgtm.

[brettw, 2015-05-08 20:08:05]

correct

[brettw, 2015-05-08 20:08:12]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-05-08 20:08:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123283003/1

[brettw, 2015-05-08 20:29:45]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-05-08 20:31:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123283003/1

[commit-bot: I haz the power, 2015-05-08 22:28:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-08 22:29:32]

Patchset 1 (id:??) landed as
https://crrev.com/22d6ca1804b55d97852dc6c92e480f173c3909a8
Cr-Commit-Position: refs/heads/master@{#329022}