Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1123263005: [Android] Remove hand-rolled adb devices call from bb_device_status_check. (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
Reviewers:
navabi1, navabi
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove hand-rolled adb devices call from bb_device_status_check. BUG=489219, 267773 Committed: https://crrev.com/f953e418bc56e5f07e600479832e2141683b15a6 Cr-Commit-Position: refs/heads/master@{#330702}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nit #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -46 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 1 2 14 chunks +32 lines, -46 lines 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
jbudorick
5 years, 7 months ago (2015-05-18 16:30:00 UTC) #2
navabi
lgtm with nit. https://codereview.chromium.org/1123263005/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/1123263005/diff/1/build/android/buildbot/bb_device_status_check.py#newcode312 build/android/buildbot/bb_device_status_check.py:312: # TODO(navabi): Test to make sure ...
5 years, 7 months ago (2015-05-19 20:21:00 UTC) #4
navabi1
lgtm with nit commented with my google account.
5 years, 7 months ago (2015-05-19 20:21:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123263005/20001
5 years, 7 months ago (2015-05-19 22:46:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/54599) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-19 22:54:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123263005/40001
5 years, 7 months ago (2015-05-20 04:29:07 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 05:21:16 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 05:22:07 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f953e418bc56e5f07e600479832e2141683b15a6
Cr-Commit-Position: refs/heads/master@{#330702}

Powered by Google App Engine
This is Rietveld 408576698