Initialize POD members of ApplicationManager, and other drive-by's.

Initialize POD members of ApplicationManager, and other drive-by's.

In particular, disable_cache_ is flapping in the wind. It's not actually
a bug "in real life" (i.e., the Context initializes it by calling
set_disable_cache()), but makes you wonder about, e.g., the tests for
ApplicationManager.

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/768bef7a17a825e752a51d91b23b787495678c07

[jamesr, 2015-05-14 22:11:23]

we need to enable all the *sans

lgtm

https://codereview.chromium.org/1123263004/diff/1/shell/application_manager/a...
File shell/application_manager/application_manager.cc (right):

https://codereview.chromium.org/1123263004/diff/1/shell/application_manager/a...
shell/application_manager/application_manager.cc:100: blocking_pool_(),
could you say blocking_pool_(nullptr)?  I know this does the same but it's a
corner of C++ that a surprising number of people don't know and having the type
info repeated here is useful

[viettrungluu, 2015-05-14 22:20:35]

Thanks.

On 2015/05/14 22:11:23, jamesr wrote:
> we need to enable all the *sans
> 
> lgtm
> 
>
https://codereview.chromium.org/1123263004/diff/1/shell/application_manager/a...
> File shell/application_manager/application_manager.cc (right):
> 
>
https://codereview.chromium.org/1123263004/diff/1/shell/application_manager/a...
> shell/application_manager/application_manager.cc:100: blocking_pool_(),
> could you say blocking_pool_(nullptr)?  I know this does the same but it's a
> corner of C++ that a surprising number of people don't know and having the
type
> info repeated here is useful

Done.

[viettrungluu, 2015-05-14 22:20:50]

Committed patchset #2 (id:20001) manually as
768bef7a17a825e752a51d91b23b787495678c07 (presubmit successful).