Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1123253004: Mention default and minimum for ExtensionCacheSize policy. (Closed)

Created:
5 years, 7 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 7 months ago
Reviewers:
bartfab (slow), Bin
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Bin
Base URL:
https://chromium.googlesource.com/chromium/src.git@gperftools_prof_timer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mention default and minimum for ExtensionCacheSize policy. This expands the documentation on the protobuf definition for the ExtensionCacheSize policy to mention the minimum allowed value and the default. BUG=none Committed: https://crrev.com/7d4bbed5f47a77946f4fb07f3ccc3a32ecec0d9c Cr-Commit-Position: refs/heads/master@{#330063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Mattias Nissler (ping if slow)
Please review.
5 years, 7 months ago (2015-05-13 08:50:44 UTC) #2
Mattias Nissler (ping if slow)
+binzhao@ to CC
5 years, 7 months ago (2015-05-13 08:51:05 UTC) #3
bartfab (slow)
lgtm
5 years, 7 months ago (2015-05-13 12:34:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123253004/1
5 years, 7 months ago (2015-05-13 12:35:00 UTC) #6
Mattias Nissler (ping if slow)
Stopping CQ to give Bin a chance to take a look.
5 years, 7 months ago (2015-05-13 12:52:59 UTC) #8
Bin
lgtm
5 years, 7 months ago (2015-05-14 00:03:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123253004/1
5 years, 7 months ago (2015-05-15 07:48:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 08:19:55 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 08:20:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d4bbed5f47a77946f4fb07f3ccc3a32ecec0d9c
Cr-Commit-Position: refs/heads/master@{#330063}

Powered by Google App Engine
This is Rietveld 408576698