Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1123243006: Add UMA stats for icon-based NTP. (Closed)

Created:
5 years, 7 months ago by newt (away)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA stats for icon-based NTP. These stats are currently used by internal code, but that code will be moved into Chromium soon. BUG=483656 Committed: https://crrev.com/01d9b43f17709a27a936474a3808f7bcdab6db35 Cr-Commit-Position: refs/heads/master@{#329701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
newt (away)
PTAL
5 years, 7 months ago (2015-05-13 00:45:47 UTC) #2
beaudoin
LGTM
5 years, 7 months ago (2015-05-13 01:48:03 UTC) #3
Alexei Svitkine (slow)
Can you link to the CL that implemented this? Usually it's best to have the ...
5 years, 7 months ago (2015-05-13 14:37:45 UTC) #4
newt (away)
The stats are currently used here: https://chrome-internal-review.googlesource.com/#/c/216165/ but that code will be moved into Chromium ...
5 years, 7 months ago (2015-05-13 17:47:07 UTC) #5
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-05-13 17:50:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123243006/1
5 years, 7 months ago (2015-05-13 17:54:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 19:57:32 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:58:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01d9b43f17709a27a936474a3808f7bcdab6db35
Cr-Commit-Position: refs/heads/master@{#329701}

Powered by Google App Engine
This is Rietveld 408576698