Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123243005: Address mfoltz's feedback for the Media Router Mojo type converters. (Closed)

Created:
5 years, 7 months ago by Kevin M
Modified:
5 years, 7 months ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, posciak+watch_chromium.org, media-router+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address mfoltz's feedback for the Media Router Mojo type converters. R=mfoltz@chromium.org BUG=464205 Committed: https://crrev.com/6a846b53ea15a005dc4e7cb5807297cb396d29c9 Cr-Commit-Position: refs/heads/master@{#329667}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sync with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -60 lines) Patch
M chrome/browser/media/router/media_router_type_converters.h View 3 chunks +7 lines, -45 lines 0 comments Download
M chrome/browser/media/router/media_router_type_converters.cc View 1 2 chunks +63 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_type_converters_unittest.cc View 5 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Kevin M
5 years, 7 months ago (2015-05-12 21:49:59 UTC) #1
mark a. foltz
lgtm https://codereview.chromium.org/1123243005/diff/1/chrome/browser/media/router/media_router_type_converters.cc File chrome/browser/media/router/media_router_type_converters.cc (right): https://codereview.chromium.org/1123243005/diff/1/chrome/browser/media/router/media_router_type_converters.cc#newcode8 chrome/browser/media/router/media_router_type_converters.cc:8: Consider adding using media_router::interfaces::{MediaSinkPtr,MediaRoutePtr,IssuePtr,...} to make the converters ...
5 years, 7 months ago (2015-05-13 01:56:34 UTC) #2
Kevin M
https://codereview.chromium.org/1123243005/diff/1/chrome/browser/media/router/media_router_type_converters.cc File chrome/browser/media/router/media_router_type_converters.cc (right): https://codereview.chromium.org/1123243005/diff/1/chrome/browser/media/router/media_router_type_converters.cc#newcode8 chrome/browser/media/router/media_router_type_converters.cc:8: On 2015/05/13 01:56:34, mark a. foltz wrote: > Consider ...
5 years, 7 months ago (2015-05-13 16:45:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123243005/20001
5 years, 7 months ago (2015-05-13 16:50:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 17:39:14 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 17:40:05 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6a846b53ea15a005dc4e7cb5807297cb396d29c9
Cr-Commit-Position: refs/heads/master@{#329667}

Powered by Google App Engine
This is Rietveld 408576698