Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1123233005: Simplify frame loads in OriginReplication and SandboxFlagsReplication tests. (Closed)

Created:
5 years, 7 months ago by alexmos
Modified:
5 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify frame loads in OriginReplication and SandboxFlagsReplication tests. Recent work on didStopLoading makes it possible for us to use WaitForLoadStop to wait for all child frames to be loaded when navigating a subframe. BUG= Committed: https://crrev.com/54dee8e8bab33b439b4973cdcfb961e7d0d0b6e4 Cr-Commit-Position: refs/heads/master@{#330155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M content/browser/site_per_process_browsertest.cc View 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alexmos
Hey Nasko, can you please take a look? This should make these two tests friendier ...
5 years, 7 months ago (2015-05-15 18:49:53 UTC) #2
nasko
LGTM
5 years, 7 months ago (2015-05-15 18:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123233005/1
5 years, 7 months ago (2015-05-15 18:57:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 19:07:11 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 19:08:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54dee8e8bab33b439b4973cdcfb961e7d0d0b6e4
Cr-Commit-Position: refs/heads/master@{#330155}

Powered by Google App Engine
This is Rietveld 408576698