Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1123213005: Add tests for chromium.mac's Mac10.10 builder (Closed)

Created:
5 years, 7 months ago by smut
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for chromium.mac's Mac10.10 builder This adds the tests which are green on chromium.fyi's Chromium Mac 10.10 builder. BUG=449316 Committed: https://crrev.com/2e63dba0d3d2b1504f5c3630e181d9b48c9c98f5 Cr-Commit-Position: refs/heads/master@{#329760}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Canonicalize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -0 lines) Patch
M testing/buildbot/chromium.mac.json View 1 1 chunk +153 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
smut
5 years, 7 months ago (2015-05-06 23:39:52 UTC) #2
erikchen
lgtm https://codereview.chromium.org/1123213005/diff/1/testing/buildbot/chromium.mac.json File testing/buildbot/chromium.mac.json (right): https://codereview.chromium.org/1123213005/diff/1/testing/buildbot/chromium.mac.json#newcode903 testing/buildbot/chromium.mac.json:903: "can_use_on_swarming_builders": true This currently has no effect, right? ...
5 years, 7 months ago (2015-05-08 18:54:37 UTC) #3
smut
https://codereview.chromium.org/1123213005/diff/1/testing/buildbot/chromium.mac.json File testing/buildbot/chromium.mac.json (right): https://codereview.chromium.org/1123213005/diff/1/testing/buildbot/chromium.mac.json#newcode903 testing/buildbot/chromium.mac.json:903: "can_use_on_swarming_builders": true On 2015/05/08 18:54:36, erikchen wrote: > This ...
5 years, 7 months ago (2015-05-08 19:03:57 UTC) #4
smut
+dpranke for OWNERS
5 years, 7 months ago (2015-05-08 20:34:46 UTC) #6
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-08 23:04:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123213005/20001
5 years, 7 months ago (2015-05-08 23:30:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 03:51:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123213005/20001
5 years, 7 months ago (2015-05-13 23:11:08 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 00:24:30 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 00:25:29 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e63dba0d3d2b1504f5c3630e181d9b48c9c98f5
Cr-Commit-Position: refs/heads/master@{#329760}

Powered by Google App Engine
This is Rietveld 408576698