Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: src/compiler/verifier.cc

Issue 1123213002: [turbofan] Connect non-terminating loops via Terminate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/common-operator-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 4dd0b6470648e6799ef4ce50c657cc7f9b9064bd..e7580037fb04003d0a95055d93b4f7e1ee3ff955 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -168,16 +168,6 @@ void Verifier::Visitor::Check(Node* node) {
}
switch (node->opcode()) {
- case IrOpcode::kAlways:
- // Always has no inputs.
- CHECK_EQ(0, input_count);
- // Always uses are Branch.
- for (auto use : node->uses()) {
- CHECK(use->opcode() == IrOpcode::kBranch);
- }
- // Type is boolean.
- CheckUpperIs(node, Type::Boolean());
- break;
case IrOpcode::kStart:
// Start has no inputs.
CHECK_EQ(0, input_count);
@@ -293,6 +283,15 @@ void Verifier::Visitor::Check(Node* node) {
// Type is empty.
CheckNotTyped(node);
break;
+ case IrOpcode::kTerminate:
+ CHECK_EQ(IrOpcode::kLoop,
+ NodeProperties::GetControlInput(node)->opcode());
+ // Type is empty.
+ CheckNotTyped(node);
+ CHECK_EQ(1, control_count);
+ CHECK_EQ(1, effect_count);
+ CHECK_EQ(2, input_count);
+ break;
case IrOpcode::kOsrNormalEntry:
case IrOpcode::kOsrLoopEntry:
// Osr entries have
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/common-operator-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698