Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1123213002: [turbofan] Connect non-terminating loops via Terminate. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Connect non-terminating loops via Terminate. This revives the Terminate operator and removes the weird Always operator. As a first step we let the ControlReducer connect non terminating loops via Terminate. The next step will be to change the graph builder to insert Terminate nodes into every loop. Committed: https://crrev.com/203438d9bc0866460d15823143ffb2236dd149a5 Cr-Commit-Position: refs/heads/master@{#28259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -100 lines) Patch
M src/compiler/common-operator.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler/common-operator.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 3 chunks +11 lines, -20 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/opcodes.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/scheduler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/control-reducer-unittest.cc View 4 chunks +10 lines, -38 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +2 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 3 chunks +37 lines, -5 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Ben, Reviving good old Terminate and remove the lovely Always... Please take a look. ...
5 years, 7 months ago (2015-05-06 12:28:55 UTC) #2
titzer
On 2015/05/06 12:28:55, Benedikt Meurer wrote: > Hey Ben, > > Reviving good old Terminate ...
5 years, 7 months ago (2015-05-06 12:31:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123213002/1
5 years, 7 months ago (2015-05-06 12:32:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 12:51:45 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 12:51:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/203438d9bc0866460d15823143ffb2236dd149a5
Cr-Commit-Position: refs/heads/master@{#28259}

Powered by Google App Engine
This is Rietveld 408576698