Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3746)

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 11232060: Make sure sideload wipeout doesn't interfere with the tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar_view.cc
===================================================================
--- chrome/browser/ui/views/toolbar_view.cc (revision 163351)
+++ chrome/browser/ui/views/toolbar_view.cc (working copy)
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/views/toolbar_view.h"
+#include "base/bind.h"
#include "base/i18n/number_formatting.h"
#include "base/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
@@ -111,9 +112,6 @@
const int kSearchTopLocationBarSpacing = 2;
const int kSearchToolbarSpacing = 5;
-// How often to show the disabled extension (sideload wipeout) bubble.
-const int kShowSideloadWipeoutBubbleMax = 3;
-
gfx::ImageSkia* kPopupBackgroundEdge = NULL;
// The omnibox border has some additional shadow, so we use less vertical
@@ -313,9 +311,6 @@
location_bar_->Init(popup_parent_view);
show_home_button_.Init(prefs::kShowHomeButton,
browser_->profile()->GetPrefs(), this);
- sideload_wipeout_bubble_shown_.Init(
- prefs::kExtensionsSideloadWipeoutBubbleShown,
- browser_->profile()->GetPrefs(), NULL);
browser_actions_->Init();
@@ -327,10 +322,9 @@
l10n_util::GetStringUTF16(IDS_ACCNAME_TOOLTIP_FORWARD));
}
- int bubble_shown_count = sideload_wipeout_bubble_shown_.GetValue();
- if (bubble_shown_count < kShowSideloadWipeoutBubbleMax &&
- DisabledExtensionsView::MaybeShow(browser_, app_menu_))
- sideload_wipeout_bubble_shown_.SetValue(++bubble_shown_count);
+ MessageLoop::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&DisabledExtensionsView::MaybeShow, browser_, app_menu_));
}
void ToolbarView::Update(WebContents* tab, bool should_restore_state) {

Powered by Google App Engine
This is Rietveld 408576698