jingle/notifier/listener/non_blocking_push_client.h - Issue 11232048: Adding XMPP ping functionality to CLoudPrint. XMPP ping and timeout is controlled thorugh Service S…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: jingle/notifier/listener/non_blocking_push_client.h

Issue 11232048: Adding XMPP ping functionality to CLoudPrint. XMPP ping and timeout is controlled thorugh Service S… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments addressed Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« jingle/notifier/listener/fake_push_client.cc ('K') | « jingle/notifier/listener/fake_push_client.cc ('k') | jingle/notifier/listener/non_blocking_push_client.cc » ('j') | jingle/notifier/listener/send_ping_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: jingle/notifier/listener/non_blocking_push_client.h

diff --git a/jingle/notifier/listener/non_blocking_push_client.h b/jingle/notifier/listener/non_blocking_push_client.h

index 434f5f4ec68070e37f309ece5af72e102852045c..f5c6bc48e095a05e406115b794d2538260bf08c5 100644

--- a/jingle/notifier/listener/non_blocking_push_client.h

+++ b/jingle/notifier/listener/non_blocking_push_client.h

@@ -49,6 +49,7 @@ class NonBlockingPushClient : public PushClient {

virtual void UpdateCredentials(

const std::string& email, const std::string& token) OVERRIDE;

virtual void SendNotification(const Notification& notification) OVERRIDE;

+ virtual void SendPing() OVERRIDE;

akalin 2012/10/25 00:10:13 add unit test for this please

gene 2012/10/25 00:43:26 Done.

private:

class Core;

@@ -56,6 +57,7 @@ class NonBlockingPushClient : public PushClient {

void OnNotificationsEnabled();

void OnNotificationsDisabled(NotificationsDisabledReason reason);

void OnIncomingNotification(const Notification& notification);

+ void OnPingResponse();

base::ThreadChecker thread_checker_;

base::WeakPtrFactory<NonBlockingPushClient> weak_ptr_factory_;