Adding XMPP ping functionality to CLoudPrint. XMPP ping and timeout is controlled thorugh Service S…

chrome/service/cloud_print/connector_settings.h

Index: chrome/service/cloud_print/connector_settings.h
diff --git a/chrome/service/cloud_print/connector_settings.h b/chrome/service/cloud_print/connector_settings.h
index 9750727b594e72be61c9dc87c4b9623193d78e97..4c9b086cf4df55e0c70213c8650ba2c1672ff09f 100644
--- a/chrome/service/cloud_print/connector_settings.h
+++ b/chrome/service/cloud_print/connector_settings.h
@@ -42,12 +42,26 @@ class ConnectorSettings {
     return connect_new_printers_;
   };
 
+  bool xmpp_ping_enabled() const {
+    return xmpp_ping_enabled_;
+  }
+
+  void set_xmpp_ping_enabled(bool enabled) {
+    xmpp_ping_enabled_ = enabled;
+  }
+
+  int xmpp_ping_timeout_sec() const {
+    return xmpp_ping_timeout_sec_;
+  }
+
   const base::DictionaryValue* print_system_settings() const {
     return print_system_settings_.get();
   };
 
   bool IsPrinterBlacklisted(const std::string& name) const;
 
+  void SetXmppPingTimeoutSec(int timeout);
+
  private:
   // Cloud Print server url.
   GURL server_url_;
@@ -63,6 +77,12 @@ class ConnectorSettings {
   // If true register all new printers in cloud print.
   bool connect_new_printers_;
 
+  // Indicate if XMPP pings are enabled.
+  bool xmpp_ping_enabled_;
+
+  // Indicate timeout between XMPP pings.
+  int xmpp_ping_timeout_sec_;

[akalin, 2012/10/25 00:10:13]

why not store this as a base::TimeDelta?

[gene, 2012/10/25 00:43:26]

I assume you suggesting to do
base::TimeDelta::FromSeconds(
      base::RandInt(settings_.xmpp_ping_timeout_sec() * 0.9,
                    settings_.xmpp_ping_timeout_sec() * 1.1))
and store the result?

This actually represent a state of the Service State file and I would prefer to
keep it closer to the content of the file.

+
   // List of printers which should not be connected.
   std::set<std::string> printer_blacklist_;