jingle/notifier/listener/push_notifications_send_update_task.h - Issue 11232048: Adding XMPP ping functionality to CLoudPrint. XMPP ping and timeout is controlled thorugh Service S…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: jingle/notifier/listener/push_notifications_send_update_task.h

Issue 11232048: Adding XMPP ping functionality to CLoudPrint. XMPP ping and timeout is controlled thorugh Service S… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« jingle/notifier/listener/push_notifications_listen_task.cc ('K') | « jingle/notifier/listener/push_notifications_listen_task.cc ('k') | jingle/notifier/listener/push_notifications_send_update_task.cc » ('j') | jingle/notifier/listener/push_notifications_send_update_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: jingle/notifier/listener/push_notifications_send_update_task.h

diff --git a/jingle/notifier/listener/push_notifications_send_update_task.h b/jingle/notifier/listener/push_notifications_send_update_task.h

index 36bb3c35540ecd9b57eed8fdd3802e807998aa81..d643bc0c93430dd3b5133edbec99ff2b0d04fed7 100644

--- a/jingle/notifier/listener/push_notifications_send_update_task.h

+++ b/jingle/notifier/listener/push_notifications_send_update_task.h

@@ -34,10 +34,15 @@ class PushNotificationsSendUpdateTask : public buzz::XmppTask {

static buzz::XmlElement* MakeUpdateMessage(

const Notification& notification, const buzz::Jid& to_jid_bare);

+ static buzz::XmlElement* MakePingStanza(const Notification& notification,

+ std::string task_id);

Vitaly Buka (NO REVIEWS) 2012/10/22 20:52:53 const std::string&

gene 2012/10/22 21:44:12 Done.

const Notification notification_;

FRIEND_TEST_ALL_PREFIXES(PushNotificationsSendUpdateTaskTest,

MakeUpdateMessage);

+ FRIEND_TEST_ALL_PREFIXES(PushNotificationsSendUpdateTaskTest,

+ MakePingStanza);

DISALLOW_COPY_AND_ASSIGN(PushNotificationsSendUpdateTask);

};