Issue 1123203002: Deflake LayoutTests/svg/animations/dynamic-modify-transform-without-baseval.html [timeout]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1123203002: Deflake LayoutTests/svg/animations/dynamic-modify-transform-without-baseval.html [timeout]

Created:
5 years, 7 months ago by payal.pandey

Modified:
5 years, 7 months ago

Reviewers:
pdr., fs

CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Deflake LayoutTests/svg/animations/dynamic-modify-transform-without-baseval.html [timeout] Increment the timeout val of changeTransform() from 1 to 3 miliseconds. BUG=454729

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	LayoutTests/svg/animations/dynamic-modify-transform-without-baseval.html	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

5 years, 7 months ago (2015-05-06 09:32:29 UTC) #3

https://codereview.chromium.org/1123203002/diff/1/LayoutTests/svg/animations/...
File LayoutTests/svg/animations/dynamic-modify-transform-without-baseval.html
(right):

https://codereview.chromium.org/1123203002/diff/1/LayoutTests/svg/animations/...
LayoutTests/svg/animations/dynamic-modify-transform-without-baseval.html:15:
setTimeout("changeTransform()", 3);
This looks like it "raises the bar" for flakyness, can we use some other trigger
instead?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages