Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1123193002: Update checkstyle version from chromium to match presubmit. (Closed)

Created:
5 years, 7 months ago by qsr
Modified:
5 years, 7 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@add_service_cache
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unrelated CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/checkstyle/README.chromium View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/checkstyle/checkstyle-6.1-all.jar View Binary file 0 comments Download
A + third_party/checkstyle/checkstyle-6.5-all.jar View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
qsr
5 years, 7 months ago (2015-05-06 08:18:59 UTC) #1
qsr
Committed patchset #2 (id:20001) manually as 33c4e5b38d7a309807aed0049a9e8faf8b6e5dbf (presubmit successful).
5 years, 7 months ago (2015-05-06 08:20:25 UTC) #2
jamesr
5 years, 7 months ago (2015-05-06 13:43:17 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698