Respect opt_scopes in getNewToken.

Respect opt_scopes in getNewToken.

Without this, the downscoped token was being revoked, but the call to get a
fresh one was returning the cached non-downscoped token.

Also adds an assert to catch regressions.

BUG=b/20662147

Committed: https://crrev.com/c7cd74f28ffab679477ca8ef41e9e27b9ceea9d3
Cr-Commit-Position: refs/heads/master@{#329711}

[Jamie, 2015-05-08 21:48:07]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Jamie, 2015-05-08 21:48:08]

ptal

[kelvinp, 2015-05-11 17:17:33]

lgtm with comments

https://codereview.chromium.org/1123183005/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/app_connected_view.js (right):

https://codereview.chromium.org/1123183005/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/app_connected_view.js:252: var previousToken_ =
'';
This can be moved inside the scope of sendGoogleDriveAccessToken_

[Jamie, 2015-05-11 17:22:59]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-05-11 17:23:09]

FYI

https://codereview.chromium.org/1123183005/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/app_connected_view.js (right):

https://codereview.chromium.org/1123183005/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/app_connected_view.js:252: var previousToken_ =
'';
On 2015/05/11 17:17:33, kelvinp wrote:
> This can be moved inside the scope of sendGoogleDriveAccessToken_

I think it's clearer as a global. Javascript scoping and lifetime rules for vars
are a bit unusual to someone not well versed in the language, and since we're in
a IIFE, there's little benefit to scoping it more tightly than this.

[commit-bot: I haz the power, 2015-05-11 17:33:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123183005/1

[commit-bot: I haz the power, 2015-05-11 18:53:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 18:53:50]

Failed to apply patch for remoting/webapp/crd/js/identity.js:
While running git apply --index -3 -p1;
  error: remoting/webapp/crd/js/identity.js: does not exist in index

Patch:       remoting/webapp/crd/js/identity.js
Index: remoting/webapp/crd/js/identity.js
diff --git a/remoting/webapp/crd/js/identity.js
b/remoting/webapp/crd/js/identity.js
index
d53a0395d010e372a7eaf4ffc22a0dfa284fd7db..2db3f03dccb61e72d235e4f4a2e9e4590be5412e
100644
--- a/remoting/webapp/crd/js/identity.js
+++ b/remoting/webapp/crd/js/identity.js
@@ -95,7 +95,7 @@ remoting.Identity.prototype.getNewToken = function(opt_scopes)
{
   return this.getToken(opt_scopes).then(function(/** string */ token) {
     return new Promise(function(resolve, reject) {
       chrome.identity.removeCachedAuthToken({'token': token }, function() {
-        resolve(that.getToken());
+        resolve(that.getToken(opt_scopes));
       });
     });
   });

[commit-bot: I haz the power, 2015-05-11 18:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[Jamie, 2015-05-13 19:44:12]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-05-13 19:44:13]

The patchset sent to the CQ was uploaded after l-g-t-m from kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1123183005/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-05-13 19:44:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123183005/20001

[commit-bot: I haz the power, 2015-05-13 20:50:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-13 20:51:11]

Patchset 2 (id:??) landed as
https://crrev.com/c7cd74f28ffab679477ca8ef41e9e27b9ceea9d3
Cr-Commit-Position: refs/heads/master@{#329711}