Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1123183004: Move GN build file for gmock_mutant from build/secondary into the main tree. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GN build file for gmock_mutant from build/secondary into the main tree. There is no need to keep it in the secondary tree. BUG=None TEST=gn gen out-gn/Debug R=dpranke@chromium.org Committed: https://crrev.com/16f0a88eea42d7528eaa71533e1c539c0bd45962 Cr-Commit-Position: refs/heads/master@{#329102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -12 lines) Patch
D build/secondary/testing/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
A + testing/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tfarina
5 years, 7 months ago (2015-05-08 21:43:31 UTC) #1
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-08 23:06:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123183004/1
5 years, 7 months ago (2015-05-09 13:36:23 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-05-09 17:40:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123183004/1
5 years, 7 months ago (2015-05-10 00:52:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-05-10 04:55:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123183004/1
5 years, 7 months ago (2015-05-11 01:15:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 06:58:41 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 06:59:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16f0a88eea42d7528eaa71533e1c539c0bd45962
Cr-Commit-Position: refs/heads/master@{#329102}

Powered by Google App Engine
This is Rietveld 408576698