Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123173005: Experiment with find as a road to Gyp sanity. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Experiment with find as a road to Gyp sanity. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b91f7562c409f1e88edd133293e09146cd437743

Patch Set 1 #

Patch Set 2 : find.py #

Patch Set 3 : /\/\/\/\/\ #

Patch Set 4 : mv #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -196 lines) Patch
M gyp/bench.gyp View 2 chunks +0 lines, -11 lines 0 comments Download
M gyp/bench.gypi View 1 2 3 2 chunks +5 lines, -91 lines 0 comments Download
A gyp/find.py View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M gyp/iOSShell.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M gyp/nanomsg.gyp View 1 2 3 1 chunk +1 line, -86 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123173005/1
5 years, 7 months ago (2015-05-15 22:10:37 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1103) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 7 months ago (2015-05-15 22:13:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123173005/20001
5 years, 7 months ago (2015-05-15 22:23:22 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1105) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 7 months ago (2015-05-15 22:27:07 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123173005/40001
5 years, 7 months ago (2015-05-15 22:38:56 UTC) #10
mtklein_C
5 years, 7 months ago (2015-05-15 22:43:32 UTC) #12
hal.canary
On 2015/05/15 22:43:32, mtklein_C wrote: Please move find.py to either bin/ or tools/
5 years, 7 months ago (2015-05-15 23:55:37 UTC) #13
mtklein
On 2015/05/15 23:55:37, Hal Canary wrote: > On 2015/05/15 22:43:32, mtklein_C wrote: > > Please ...
5 years, 7 months ago (2015-05-16 01:31:22 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123173005/60001
5 years, 7 months ago (2015-05-16 01:32:25 UTC) #16
hal.canary
lgtm
5 years, 7 months ago (2015-05-16 01:39:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123173005/60001
5 years, 7 months ago (2015-05-16 02:17:07 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-16 22:47:14 UTC) #21
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b91f7562c409f1e88edd133293e09146cd437743

Powered by Google App Engine
This is Rietveld 408576698