Do not disable Data Reduction Proxy on VPN.

Do not disable Data Reduction Proxy on VPN.

This behavior is behind the "DataReductionProxyUseDataSaverOnVPN"
Finch trial, so Data Saver will not be disabled only for users who are part of this trial.

BUG=462497
Committed: https://crrev.com/16895a087c44f9b65eba06c09c2e9d69f80eb7d6
Cr-Commit-Position: refs/heads/master@{#330635}

[Not at Google. Contact bengr, 2015-05-15 19:46:42]

kundaji@chromium.org changed reviewers:
+ bengr@chromium.org

[Not at Google. Contact bengr, 2015-05-15 19:47:27]

bengr:
  components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
  components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
 
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
  components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

[bengr, 2015-05-15 21:28:52]

Say a little more in the CL description. E.g., mention that it sets up a field
trial to use the Data Reduction Proxy, even if on a VPN.

https://codereview.chromium.org/1123173004/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
(right):

https://codereview.chromium.org/1123173004/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc:563:
bool DataReductionProxyConfig::MaybeDisableIfVPN() {
Rename as ShouldDisableIfVPN()

https://codereview.chromium.org/1123173004/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc:571:
const std::string vpn_interface_name_prefix = "tun";
Add a comment that this only works on Android and Linux, or condition it to
those platforms.

[Not at Google. Contact bengr, 2015-05-15 21:41:24]

https://codereview.chromium.org/1123173004/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
(right):

https://codereview.chromium.org/1123173004/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc:563:
bool DataReductionProxyConfig::MaybeDisableIfVPN() {
On 2015/05/15 21:28:52, bengr wrote:
> Rename as ShouldDisableIfVPN()

This method actually does the disabling as well. So ShouldDisableIfVPN sounds
inaccurate?

https://codereview.chromium.org/1123173004/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc:571:
const std::string vpn_interface_name_prefix = "tun";
On 2015/05/15 21:28:52, bengr wrote:
> Add a comment that this only works on Android and Linux, or condition it to
> those platforms.

Done.

[bengr, 2015-05-19 15:23:26]

lgtm

https://codereview.chromium.org/1123173004/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
(right):

https://codereview.chromium.org/1123173004/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc:563:
bool DataReductionProxyConfig::MaybeDisableIfVPN() {
On 2015/05/15 21:41:24, kundaji wrote:
> On 2015/05/15 21:28:52, bengr wrote:
> > Rename as ShouldDisableIfVPN()
> 
> This method actually does the disabling as well. So ShouldDisableIfVPN sounds
> inaccurate?

I misread the code. This is fine. An alternative (not required) is to break this
into two functions: ShouldDisableIfVPN and DisableIfVPN

[Not at Google. Contact bengr, 2015-05-19 21:56:04]

The CQ bit was checked by kundaji@chromium.org

[Not at Google. Contact bengr, 2015-05-19 21:56:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/1123173004/#ps60001
(title: "Sync to head")

[commit-bot: I haz the power, 2015-05-19 21:56:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1123173004/60001

[commit-bot: I haz the power, 2015-05-19 22:28:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-19 22:29:20]

Patchset 4 (id:??) landed as
https://crrev.com/16895a087c44f9b65eba06c09c2e9d69f80eb7d6
Cr-Commit-Position: refs/heads/master@{#330635}