tools/dom/scripts/htmlrenamer.py - Issue 1123173003: Another try at appendHtml and insertAdjacentHtml should be consistently sanitized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmlrenamer.py

Issue 1123173003: Another try at appendHtml and insertAdjacentHtml should be consistently sanitized (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart ('k') | tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/htmlrenamer.py

diff --git a/tools/dom/scripts/htmlrenamer.py b/tools/dom/scripts/htmlrenamer.py

index 40ee519f45254a56cd178d9f4b2e84d3b91c3db4..8d0b7ee9b48aba9917e4f51dc8c6bf38be593384 100644

--- a/tools/dom/scripts/htmlrenamer.py

+++ b/tools/dom/scripts/htmlrenamer.py

@@ -237,6 +237,7 @@ private_html_members = monitored.Set('htmlrenamer.private_html_members', [

'Element.childElementCount',

'Element.firstElementChild',

'Element.getElementsByTagName',

+ 'Element.insertAdjacentHTML',

'Element.scrollIntoView',

'Element.scrollIntoViewIfNeeded',

'Element.removeAttribute',