src/lookup.cc - Issue 1123163005: Mark internal AccessorInfo properties as "special data properties"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 1123163005: Mark internal AccessorInfo properties as "special data properties" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index 809fd0eb2ef58a3bc292867135784c569b6bebdc..85745ce3e573321ac29feebd0a8b14c9a02b9341 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -142,7 +142,9 @@ void LookupIterator::PrepareTransitionToDataProperty(

Handle<Object> value, PropertyAttributes attributes,

Object::StoreFromKeyed store_mode) {

if (state_ == TRANSITION) return;

- DCHECK_NE(LookupIterator::ACCESSOR, state_);

+ DCHECK(state_ != LookupIterator::ACCESSOR ||

+ (GetAccessors()->IsAccessorInfo() &&

+ AccessorInfo::cast(*GetAccessors())->is_special_data_property()));

DCHECK_NE(LookupIterator::INTEGER_INDEXED_EXOTIC, state_);

DCHECK(state_ == NOT_FOUND || !HolderIsReceiverOrHiddenPrototype());

// Can only be called when the receiver is a JSObject. JSProxy has to be

« no previous file with comments | « src/accessors.cc ('k') | src/objects.h » ('j') | no next file with comments »