Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1123153003: Reject empty protocol id in HTTP/2 ALTSVC frames. (Closed)

Created:
5 years, 7 months ago by Bence
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject empty protocol id in HTTP/2 ALTSVC frames. This CL lands server change 91620063 by elving. BUG=488484 Committed: https://crrev.com/2e03e11fed1b84b500a2784d33de56e69219b481 Cr-Commit-Position: refs/heads/master@{#330177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M net/spdy/spdy_framer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 7 months ago (2015-05-15 17:05:47 UTC) #2
Ryan Hamilton
lgtm
5 years, 7 months ago (2015-05-15 18:46:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123153003/1
5 years, 7 months ago (2015-05-15 19:14:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 20:00:16 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 20:02:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e03e11fed1b84b500a2784d33de56e69219b481
Cr-Commit-Position: refs/heads/master@{#330177}

Powered by Google App Engine
This is Rietveld 408576698