Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: remoting/signaling/jid_util_unittest.cc

Issue 1123153002: Added class to subscribe to GCD notifications over XMPP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-xmpp-connect2a
Patch Set: revised unit test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/signaling/jid_util.cc ('K') | « remoting/signaling/jid_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/signaling/jid_util_unittest.cc
diff --git a/remoting/signaling/jid_util_unittest.cc b/remoting/signaling/jid_util_unittest.cc
index c4e307de4e69f62ebac10d73884940c3b7486496..78b0495661048a29139b4e420e0ed45fd20c741c 100644
--- a/remoting/signaling/jid_util_unittest.cc
+++ b/remoting/signaling/jid_util_unittest.cc
@@ -16,4 +16,20 @@ TEST(JidUtil, NormalizeJid) {
EXPECT_EQ(NormalizeJid("USER@DOMAIN.com/"), "user@domain.com/");
}
+TEST(JidUtil, SplitJidResource) {
+ std::string bare_jid;
+ std::string resource_suffix;
+
+ EXPECT_TRUE(SplitJidResource("user@domain/resource", nullptr, nullptr));
+ EXPECT_TRUE(
+ SplitJidResource("user@domain/resource", &bare_jid, &resource_suffix));
+ EXPECT_EQ(bare_jid, "user@domain");
+ EXPECT_EQ(resource_suffix, "/resource");
+
+ EXPECT_FALSE(SplitJidResource("user@domain", nullptr, nullptr));
+ EXPECT_FALSE(SplitJidResource("user@domain", &bare_jid, &resource_suffix));
+ EXPECT_EQ(bare_jid, "user@domain");
+ EXPECT_EQ(resource_suffix, "");
+}
+
} // namespace remoting
« remoting/signaling/jid_util.cc ('K') | « remoting/signaling/jid_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698