Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1123143004: Add a flag for enabling Chrome Web Store Gallery widget app (Closed)

Created:
5 years, 7 months ago by tbarzic
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag for enabling Chrome Web Store Gallery widget app This enables 'Printer detected' notification, clicking on which launches Chrome Web Store widget app showing list of apps that support the detected printer. BUG=439448 Committed: https://crrev.com/cd286fd7df51bd3a860d3d0549a5239bce759342 Cr-Commit-Position: refs/heads/master@{#330112}

Patch Set 1 #

Patch Set 2 : ./ #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Patch Set 5 : histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tbarzic
5 years, 7 months ago (2015-05-13 20:42:39 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/1123143004/diff/40001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/1123143004/diff/40001/chrome/app/chromeos_strings.grdp#newcode6366 chrome/app/chromeos_strings.grdp:6366: Enables Chrome Web Store Gallery app that searches ...
5 years, 7 months ago (2015-05-13 23:08:38 UTC) #3
tbarzic
https://codereview.chromium.org/1123143004/diff/40001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/1123143004/diff/40001/chrome/app/chromeos_strings.grdp#newcode6366 chrome/app/chromeos_strings.grdp:6366: Enables Chrome Web Store Gallery app that searches Chrome ...
5 years, 7 months ago (2015-05-14 00:13:04 UTC) #4
tbarzic
5 years, 7 months ago (2015-05-14 16:27:53 UTC) #6
Ilya Sherman
histograms.xml lgtm
5 years, 7 months ago (2015-05-14 19:10:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123143004/80001
5 years, 7 months ago (2015-05-15 16:01:00 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-15 16:57:33 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:59:31 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cd286fd7df51bd3a860d3d0549a5239bce759342
Cr-Commit-Position: refs/heads/master@{#330112}

Powered by Google App Engine
This is Rietveld 408576698